Skip to content

Conversation

JavaProgrammerLB
Copy link
Contributor

@JavaProgrammerLB JavaProgrammerLB commented Sep 11, 2025

Motivation and Context

  • fix typo in SamplingRequest.tsx which config default role(should choose from 'user' or 'assistant') value to 'endTurn'

How Has This Been Tested?

when I update role to 'endTurn' and click 'approve' I met the error('endTurn' is not allowed value)

截屏2025-09-11 17 29 39

when I update role to 'assistant' and click 'approve', everthing goes well

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@cliffhall cliffhall closed this Oct 10, 2025
@cliffhall cliffhall reopened this Oct 10, 2025
Copy link
Member

@cliffhall cliffhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@cliffhall cliffhall merged commit 321100b into modelcontextprotocol:main Oct 10, 2025
5 checks passed
@JavaProgrammerLB JavaProgrammerLB deleted the fixWrongRoleValue branch October 10, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants